Patch: pluralize removeFile/removeFolder API
aleixpol at kde.org
Thu Oct 14 00:10:01 UTC 2010
On Thu, Oct 14, 2010 at 1:55 AM, Olivier JG <olivier.jg at gmail.com> wrote:
> On 10/13/2010 11:38 PM, Aleix Pol wrote:
>> API wise:
>> - You can't call it removeFilesAndFolders and pass ProjectBaseItem's
>> because there might be targets there too (target removal doesn't work with
>> cmake yet, though, but we could add that easy). Maybe removeItems()?
> That was my idea originally, but then I noticed that removeTarget is in
> IBuildSystemManager. IOW, from the API point of view, as it stands, removing
> files/folders and targets are two different things. I asked Milian and he
> said to keep it that way and go with removeFIlesAndFolders.
> As far as what to do, currently the ProjectManagers get a nice clean list
> of only folders and files passed to removeFilesAndFolders, and as long as it
> stays that way, it's not an issue. Perhaps I should ASSERT that stance
> Thanks for reviewing
> -Olivier JG
> KDevelop-devel mailing list
> KDevelop-devel at kdevelop.org
Fine, assert in case a target is passed.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the KDevelop-devel