KSharedPtr DUChainBase::weakPointer -> QWeakPointer?

[Milian Wolff]

On Wednesday 20 January 2010 01:27:57 David Nolden wrote:
> Am Mittwoch 20 Januar 2010 00:14:17 schrieb Milian Wolff:
> > Hey all!
> > 
> > Shouldn't DUChainBase::weakPointer be a QWeakPointer instead of a
> > 
> >  KSharedPtr? Just asking because the name suggests it. And yes, I know
> >  QWeakPointer is new, but we depent on Qt 4.5 nowadays, so why not take
> >  advantage of it?
> 
> The duchain has an already-working and efficient scheme for weak references
> to duchain objects, and I don't see a reason to do modifications to it.
> QWeakPointer is something completely different than KSharedPtr, and
> anything else but a drop-in replacement. So using QWeakPointer would
> require a lot of needless changes. If anything, it could replace
> DUChainPointer, but before you start doing something, you should define
> what issue you want to solve, and I don't see an issue here...

OK, thanks for the clarification. And this was not so much "solving an issue" 
but more feedback to the API. As I said I thought this was due to QWeakPointer 
not existing at the time and so I just dared to ask :)

Good night David
-- 
Milian Wolff
mail at milianw.de
http://milianw.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20100120/bd8ed634/attachment.sig>