slowness of Cpp::EnvironmentFile::merge

[Milian Wolff]

David Nolden, 27.12.2010:
> The set-operations should be correct.
> 
> 14% isn't all that much, considering how much this code is doing. It merges
> the sets of all strings and macros contained in the file and in _all_ of
> its includes (recursively). I also think that this code is mainly
> problematic on macro-heavy headers, so your test might not be
> representative. During most of my profilings, I got something around 5% I
> think.
> 
> However, after I've already disabled most of the environment-management, I
> will have to rethink whether we really need all this information. At least
> the macro-sets are definitely required, but maybe we don't need the
> string-sets any more.
> 
> On an implementation level, there is not much room for optimizations.

OK, thanks for the clarifications.

bye
-- 
Milian Wolff
mail at milianw.de
http://milianw.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20101227/955b188a/attachment.sig>