Review Request: New testcase for ExpressionParser

[Bertjan Broeksema]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1742/
-----------------------------------------------------------

(Updated 2009-10-01 09:37:13.175997)


Review request for KDevelop and David Nolden.


Changes
-------

Felt like fixing it. So I present a fix for the bug (also fixes volatile modifier). Additionally I merged the code with the TypeASTVisitor as mentioned in the code to prevent further duplication.


Summary
-------

A test case to show incorrect parsing of "const char*" to "char *" in ExpressionParser.


Diffs (updated)
-----

  trunk/KDE/kdevelop/languages/cpp/cppduchain/expressionvisitor.cpp 1029180 
  trunk/KDE/kdevelop/languages/cpp/cppduchain/tests/test_expressionparser.h 1029661 
  trunk/KDE/kdevelop/languages/cpp/cppduchain/tests/test_expressionparser.cpp 1029661 
  trunk/KDE/kdevelop/languages/cpp/cppduchain/type_visitor.cpp 1029180 

Diff: http://reviewboard.kde.org/r/1742/diff


Testing (updated)
-------

Run all cppduchain tests. Those work fine except for the cppcodegentest, but as mentioned before, these seems b0rked anyhow.


Thanks,

Bertjan