Review Request: New testcase for ExpressionParser
David Nolden
zwabel+reviewboard at gmail.com
Thu Oct 1 09:50:10 UTC 2009
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1742/#review2514
-----------------------------------------------------------
Ship it!
Without that one if(), and of course if the duchain tests still succeed, feel free to commit
- David
On 2009-10-01 09:37:13, Bertjan Broeksema wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1742/
> -----------------------------------------------------------
>
> (Updated 2009-10-01 09:37:13)
>
>
> Review request for KDevelop and David Nolden.
>
>
> Summary
> -------
>
> A test case to show incorrect parsing of "const char*" to "char *" in ExpressionParser.
>
>
> Diffs
> -----
>
> trunk/KDE/kdevelop/languages/cpp/cppduchain/expressionvisitor.cpp 1029180
> trunk/KDE/kdevelop/languages/cpp/cppduchain/tests/test_expressionparser.h 1029661
> trunk/KDE/kdevelop/languages/cpp/cppduchain/tests/test_expressionparser.cpp 1029661
> trunk/KDE/kdevelop/languages/cpp/cppduchain/type_visitor.cpp 1029180
>
> Diff: http://reviewboard.kde.org/r/1742/diff
>
>
> Testing
> -------
>
> Run all cppduchain tests. Those work fine except for the cppcodegentest, but as mentioned before, these seems b0rked anyhow.
>
>
> Thanks,
>
> Bertjan
>
>
More information about the KDevelop-devel
mailing list