Review Request: New testcase for ExpressionParser

[David Nolden]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1742/#review2513
-----------------------------------------------------------



trunk/KDE/kdevelop/languages/cpp/cppduchain/expressionvisitor.cpp
<http://reviewboard.kde.org/r/1742/#comment1839>

    This (tvisitor.type()) check is not required, if the visitor fails a zero type is created, which is good as then m_lastType should also be zero.


- David


On 2009-10-01 09:37:13, Bertjan Broeksema wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1742/
> -----------------------------------------------------------
> 
> (Updated 2009-10-01 09:37:13)
> 
> 
> Review request for KDevelop and David Nolden.
> 
> 
> Summary
> -------
> 
> A test case to show incorrect parsing of "const char*" to "char *" in ExpressionParser.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdevelop/languages/cpp/cppduchain/expressionvisitor.cpp 1029180 
>   trunk/KDE/kdevelop/languages/cpp/cppduchain/tests/test_expressionparser.h 1029661 
>   trunk/KDE/kdevelop/languages/cpp/cppduchain/tests/test_expressionparser.cpp 1029661 
>   trunk/KDE/kdevelop/languages/cpp/cppduchain/type_visitor.cpp 1029180 
> 
> Diff: http://reviewboard.kde.org/r/1742/diff
> 
> 
> Testing
> -------
> 
> Run all cppduchain tests. Those work fine except for the cppcodegentest, but as mentioned before, these seems b0rked anyhow.
> 
> 
> Thanks,
> 
> Bertjan
> 
>