Review Request: Use ksysguard widget to attach to a process

[Niko Sams]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/646/#review1027
-----------------------------------------------------------


Beautiful!

For me the OK-Button gets never enabled.

- Niko


On 2009-04-30 08:11:20, Aleix Pol wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/646/
> -----------------------------------------------------------
> 
> (Updated 2009-04-30 08:11:20)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> This patches copies over the ksysguard widget from kdebase/workspace/libs and lets it to be used from kdevelop's gdb plugin to be able to chose a process.
> It is a better and more portable solution than the old one, plus it is nicer and lets us share code with ksysguard
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdevelop/debuggers/gdb/CMakeLists.txt 961312 
>   trunk/KDE/kdevelop/debuggers/gdb/debuggerplugin.cpp 961312 
>   trunk/KDE/kdevelop/debuggers/gdb/ksysguard/CMakeLists.txt PRE-CREATION 
>   trunk/KDE/kdevelop/debuggers/gdb/ksysguard/config-ksysguard.h.cmake PRE-CREATION 
>   trunk/KDE/kdevelop/debuggers/gdb/ksysguard/processcore/CMakeLists.txt PRE-CREATION 
>   trunk/KDE/kdevelop/debuggers/gdb/ksysguard/processcore/Messages.sh PRE-CREATION 
>   trunk/KDE/kdevelop/debuggers/gdb/ksysguard/processcore/process.h PRE-CREATION 
>   trunk/KDE/kdevelop/debuggers/gdb/ksysguard/processcore/process.cpp PRE-CREATION 
>   trunk/KDE/kdevelop/debuggers/gdb/ksysguard/processcore/processes.h PRE-CREATION 
>   trunk/KDE/kdevelop/debuggers/gdb/ksysguard/processcore/processes.cpp PRE-CREATION 
>   trunk/KDE/kdevelop/debuggers/gdb/ksysguard/processcore/processes_base_p.h PRE-CREATION 
>   trunk/KDE/kdevelop/debuggers/gdb/ksysguard/processcore/processes_base_p.cpp PRE-CREATION 
>   trunk/KDE/kdevelop/debuggers/gdb/ksysguard/processcore/processes_freebsd_p.cpp PRE-CREATION 
>   trunk/KDE/kdevelop/debuggers/gdb/ksysguard/processcore/processes_linux_p.cpp PRE-CREATION 
>   trunk/KDE/kdevelop/debuggers/gdb/ksysguard/processcore/processes_local_p.h PRE-CREATION 
>   trunk/KDE/kdevelop/debuggers/gdb/ksysguard/processcore/processes_local_p.cpp PRE-CREATION 
>   trunk/KDE/kdevelop/debuggers/gdb/ksysguard/processcore/processes_netbsd_p.cpp PRE-CREATION 
>   trunk/KDE/kdevelop/debuggers/gdb/ksysguard/processcore/processes_openbsd_p.cpp PRE-CREATION 
>   trunk/KDE/kdevelop/debuggers/gdb/ksysguard/processcore/processes_remote_p.h PRE-CREATION 
>   trunk/KDE/kdevelop/debuggers/gdb/ksysguard/processcore/processes_remote_p.cpp PRE-CREATION 
>   trunk/KDE/kdevelop/debuggers/gdb/ksysguard/processcore/processes_solaris_p.cpp PRE-CREATION 
>   trunk/KDE/kdevelop/debuggers/gdb/ksysguard/processui/CMakeLists.txt PRE-CREATION 
>   trunk/KDE/kdevelop/debuggers/gdb/ksysguard/processui/DisplayProcessDlg.h PRE-CREATION 
>   trunk/KDE/kdevelop/debuggers/gdb/ksysguard/processui/DisplayProcessDlg.cpp PRE-CREATION 
>   trunk/KDE/kdevelop/debuggers/gdb/ksysguard/processui/DisplayProcessUi.ui PRE-CREATION 
>   trunk/KDE/kdevelop/debuggers/gdb/ksysguard/processui/KMonitorProcessIO.h PRE-CREATION 
>   trunk/KDE/kdevelop/debuggers/gdb/ksysguard/processui/KMonitorProcessIO.cpp PRE-CREATION 
>   trunk/KDE/kdevelop/debuggers/gdb/ksysguard/processui/KMonitorProcessIO.widgets PRE-CREATION 
>   trunk/KDE/kdevelop/debuggers/gdb/ksysguard/processui/KTextEditVT.h PRE-CREATION 
>   trunk/KDE/kdevelop/debuggers/gdb/ksysguard/processui/KTextEditVT.cpp PRE-CREATION 
>   trunk/KDE/kdevelop/debuggers/gdb/ksysguard/processui/Messages.sh PRE-CREATION 
>   trunk/KDE/kdevelop/debuggers/gdb/ksysguard/processui/ProcessFilter.h PRE-CREATION 
>   trunk/KDE/kdevelop/debuggers/gdb/ksysguard/processui/ProcessFilter.cc PRE-CREATION 
>   trunk/KDE/kdevelop/debuggers/gdb/ksysguard/processui/ProcessModel.h PRE-CREATION 
>   trunk/KDE/kdevelop/debuggers/gdb/ksysguard/processui/ProcessModel.cc PRE-CREATION 
>   trunk/KDE/kdevelop/debuggers/gdb/ksysguard/processui/ProcessModel_p.h PRE-CREATION 
>   trunk/KDE/kdevelop/debuggers/gdb/ksysguard/processui/ProcessWidgetUI.ui PRE-CREATION 
>   trunk/KDE/kdevelop/debuggers/gdb/ksysguard/processui/ReniceDlg.h PRE-CREATION 
>   trunk/KDE/kdevelop/debuggers/gdb/ksysguard/processui/ReniceDlg.cc PRE-CREATION 
>   trunk/KDE/kdevelop/debuggers/gdb/ksysguard/processui/ReniceDlgUi.ui PRE-CREATION 
>   trunk/KDE/kdevelop/debuggers/gdb/ksysguard/processui/ksysguard.widgets PRE-CREATION 
>   trunk/KDE/kdevelop/debuggers/gdb/ksysguard/processui/ksysguardprocesslist.h PRE-CREATION 
>   trunk/KDE/kdevelop/debuggers/gdb/ksysguard/processui/ksysguardprocesslist.cpp PRE-CREATION 
>   trunk/KDE/kdevelop/debuggers/gdb/ksysguard/processui/svn-commit.tmp PRE-CREATION 
>   trunk/KDE/kdevelop/debuggers/gdb/processselection.h 961312 
>   trunk/KDE/kdevelop/debuggers/gdb/processselection.cpp 961312 
>   trunk/KDE/kdevelop/debuggers/gdb/stackmanager.h 961312 
>   trunk/KDE/kdevelop/debuggers/gdb/stackmanager.cpp 961312 
> 
> Diff: http://reviewboard.kde.org/r/646/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aleix
> 
>