Review Request: Use ksysguard widget to attach to a process

Kishore kitts.mailinglists at gmail.com
Tue May 5 06:33:41 UTC 2009


On Thursday 30 Apr 2009 8:41:21 pm Aleix Pol wrote:
> Summary
> -------
>
> This patches copies over the ksysguard widget from kdebase/workspace/libs
> and lets it to be used from kdevelop's gdb plugin to be able to chose a
> process. It is a better and more portable solution than the old one, plus
> it is nicer and lets us share code with ksysguard

Related to this , kdevelop failed to build here. Following is the simple diff 
that fixed it.

Index: debuggers/gdb/ksysguard/processui/CMakeLists.txt
===================================================================
--- debuggers/gdb/ksysguard/processui/CMakeLists.txt    (revision 963659)
+++ debuggers/gdb/ksysguard/processui/CMakeLists.txt    (working copy)
@@ -68,8 +68,8 @@
  #while it is not in kdelibs, we change its name
 kde4_add_library(kdev_processui SHARED ${processui_LIB_SRCS})

-target_link_libraries(kdev_processui ${KDE4_KDEUI_LIBS} processcore)
-target_link_libraries(kdev_processui LINK_INTERFACE_LIBRARIES 
${KDE4_KDEUI_LIBS} processcore)
+target_link_libraries(kdev_processui ${KDE4_KDEUI_LIBS} kdev_processcore)
+target_link_libraries(kdev_processui LINK_INTERFACE_LIBRARIES 
${KDE4_KDEUI_LIBS} kdev_processcore)

 set_target_properties(kdev_processui
    PROPERTIES VERSION ${GENERIC_LIB_VERSION}
@@ -84,7 +84,7 @@

 kde4_add_plugin(ksysguardwidgets ${ksysguardwidgets_PART_SRCS})

-target_link_libraries(ksysguardwidgets ${KDE4_KDEUI_LIBS} processui)
+target_link_libraries(ksysguardwidgets ${KDE4_KDEUI_LIBS} kdev_processui)

 install(TARGETS ksysguardwidgets DESTINATION 
${PLUGIN_INSTALL_DIR}/plugins/designer )

-- 
Cheers!
Kishore




More information about the KDevelop-devel mailing list