Review Request: Fix Qt4 app templates

Michael Leupold lemma at confuego.org
Tue Jul 7 11:27:27 UTC 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/944/
-----------------------------------------------------------

Review request for KDevelop.


Summary
-------

kapptemplate's PROJECTDIRNAME is APPNAME+VERSION (as of r783175). As the version contains a dot, generated Qt4-template apps don't compile without modifying the headers first (syntax error in #ifndef). As "#ifndef %{PROJECTDIRNAME}_%{APPNAME}_H" will resolve to "#ifndef ${APPNAME}-%{VERSION}_%{APPNAME}_H" I guess it's best to remove PROJECTDIRNAME from the templates altogether.


Diffs
-----

  /trunk/KDE/kdevelop/app_templates/cpp/CMake/cmake_qt4core/%{APPNAME}.h 992384 
  /trunk/KDE/kdevelop/app_templates/cpp/CMake/cmake_qt4core_qtest/%{APPNAME}.h 992384 
  /trunk/KDE/kdevelop/app_templates/cpp/CMake/cmake_qt4core_qtest/tests/%{APPNAME}Test.h 992384 
  /trunk/KDE/kdevelop/app_templates/cpp/CMake/cmake_qt4gui/%{APPNAME}.h 992384 

Diff: http://reviewboard.kde.org/r/944/diff


Testing
-------


Thanks,

Michael





More information about the KDevelop-devel mailing list