Review Request: Fix Qt4 app templates

[Andreas Pakulat]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/944/#review1518
-----------------------------------------------------------

Ship it!


Oh yeah, never noticed that. Totally bogus to put the project name there.

- Andreas


On 2009-07-07 04:27:27, Michael Leupold wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/944/
> -----------------------------------------------------------
> 
> (Updated 2009-07-07 04:27:27)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> kapptemplate's PROJECTDIRNAME is APPNAME+VERSION (as of r783175). As the version contains a dot, generated Qt4-template apps don't compile without modifying the headers first (syntax error in #ifndef). As "#ifndef %{PROJECTDIRNAME}_%{APPNAME}_H" will resolve to "#ifndef ${APPNAME}-%{VERSION}_%{APPNAME}_H" I guess it's best to remove PROJECTDIRNAME from the templates altogether.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdevelop/app_templates/cpp/CMake/cmake_qt4core/%{APPNAME}.h 992384 
>   /trunk/KDE/kdevelop/app_templates/cpp/CMake/cmake_qt4core_qtest/%{APPNAME}.h 992384 
>   /trunk/KDE/kdevelop/app_templates/cpp/CMake/cmake_qt4core_qtest/tests/%{APPNAME}Test.h 992384 
>   /trunk/KDE/kdevelop/app_templates/cpp/CMake/cmake_qt4gui/%{APPNAME}.h 992384 
> 
> Diff: http://reviewboard.kde.org/r/944/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael
> 
>