KDE/kdevplatform/plugins/projectmanagerview

[Andreas Pakulat]

On 18.01.09 20:06:21, Aleix Pol wrote:
> On Sun, Jan 18, 2009 at 12:36 AM, Andreas Pakulat <apaku at gmx.de> wrote:
> 
> > On 17.01.09 17:30:41, Aleix Pol Gonzalez wrote:
> > > SVN commit 912545 by apol:
> > >
> > > put some icons to some actions so that menus can be easily understood
> > > @@ -215,6 +218,7 @@
> > >          if ( !closeProjectsAdded && prjitem && prjitem->isProjectRoot()
> > )
> > >          {
> > >              KAction* close = new KAction( i18n( "Close Project(s)" ),
> > this );
> > > +            close->setIcon(KIcon("dialog-close"));
> >
> > Thats surely wrong, icon names are according to what the icon represents.
> > And Close Project is surely not for closing a dialog. Putting in icons is
> > good, but only as long as we're using the right icons. If there's no
> > proper icon please request one from the artist team via the techbase page.
> 
> Sure, you are right.
> 
> In projectcontroller.cpp we are setting "window-close" for the "Close All
> Projects" action, do you think we should use this one or remove them both?

If there's nothing better than "window-close" we shouldn't have an icon,
until the artists have created one for us. IMHO.

Andreas

-- 
"Life, loathe it or ignore it, you can't like it."
		-- Marvin, "Hitchhiker's Guide to the Galaxy"