KDE/kdevplatform/plugins/projectmanagerview

[Aleix Pol]

On Sun, Jan 18, 2009 at 12:36 AM, Andreas Pakulat <apaku at gmx.de> wrote:

> On 17.01.09 17:30:41, Aleix Pol Gonzalez wrote:
> > SVN commit 912545 by apol:
> >
> > put some icons to some actions so that menus can be easily understood
> > @@ -215,6 +218,7 @@
> >          if ( !closeProjectsAdded && prjitem && prjitem->isProjectRoot()
> )
> >          {
> >              KAction* close = new KAction( i18n( "Close Project(s)" ),
> this );
> > +            close->setIcon(KIcon("dialog-close"));
>
> Thats surely wrong, icon names are according to what the icon represents.
> And Close Project is surely not for closing a dialog. Putting in icons is
> good, but only as long as we're using the right icons. If there's no
> proper icon please request one from the artist team via the techbase page.

Sure, you are right.

In projectcontroller.cpp we are setting "window-close" for the "Close All
Projects" action, do you think we should use this one or remove them both?


>
> >              KAction* action = new KAction( i18n( "Remove Folder" ), this
> );
> > +            action->setIcon(KIcon("user-trash"));
>
> Not sure about that one either, what does dolphin use for remove
> folder/file?

This one :)


>
>
> >          }
> > -        else if(!hasTargets && item->executable())
> > +
> > +        if(!hasTargets && item->executable())
>
> Uhm, that seems unrelated, are you sure you wanted to remove the else?

Ugh yes I was, it is correct (an item will be a target _and_ an executable).
Sorry for not including that to the commit message.


>
> Andreas
>
> --
> Just because the message may never be received does not mean it is
> not worth sending.
>
> _______________________________________________
> KDevelop-devel mailing list
> KDevelop-devel at kdevelop.org
> https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20090118/9a4cc125/attachment.html>