KDE/kdevplatform/plugins/projectmanagerview

[Andreas Pakulat]

On 17.01.09 17:30:41, Aleix Pol Gonzalez wrote:
> SVN commit 912545 by apol:
> 
> put some icons to some actions so that menus can be easily understood
> @@ -215,6 +218,7 @@
>          if ( !closeProjectsAdded && prjitem && prjitem->isProjectRoot() )
>          {
>              KAction* close = new KAction( i18n( "Close Project(s)" ), this );
> +            close->setIcon(KIcon("dialog-close"));

Thats surely wrong, icon names are according to what the icon represents.
And Close Project is surely not for closing a dialog. Putting in icons is
good, but only as long as we're using the right icons. If there's no
proper icon please request one from the artist team via the techbase page.

>              KAction* action = new KAction( i18n( "Remove Folder" ), this );
> +            action->setIcon(KIcon("user-trash"));

Not sure about that one either, what does dolphin use for remove
folder/file?

>          }
> -        else if(!hasTargets && item->executable())
> +        
> +        if(!hasTargets && item->executable())

Uhm, that seems unrelated, are you sure you wanted to remove the else?

Andreas

-- 
Just because the message may never be received does not mean it is
not worth sending.