Review Request: Move CodeCompletionItem::execute inserting of parens into kdevplatform

[Matt Rogers]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/152/#review297
-----------------------------------------------------------

Ship it!


works for me. be sure to mark as submitted when committing.

- Matt


On 2009-02-22 06:07:13, Niko Sams wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/152/
> -----------------------------------------------------------
> 
> (Updated 2009-02-22 06:07:13)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> This small part is used exact the same way in C++, Php and Java. Move it into a new CC-helper file into the platform so others can use it.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdevelop/languages/cpp/completionitem.cpp 929584 
>   trunk/KDE/kdevplatform/language/CMakeLists.txt 929944 
>   trunk/KDE/kdevplatform/language/codecompletion/codecompletionhelper.h PRE-CREATION 
>   trunk/KDE/kdevplatform/language/codecompletion/codecompletionhelper.cpp PRE-CREATION 
> 
> Diff: http://reviewboard.kde.org/r/152/diff
> 
> 
> Testing
> -------
> 
> it compiles (I didn't change anything in the logic - just moved stuff around)
> 
> 
> Thanks,
> 
> Niko
> 
>