Review Request: Move CodeCompletionItem::execute inserting of parens into kdevplatform

niko.sams at gmail.com niko.sams at gmail.com
Sun Feb 22 14:07:13 UTC 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/152/
-----------------------------------------------------------

Review request for KDevelop.


Summary
-------

This small part is used exact the same way in C++, Php and Java. Move it into a new CC-helper file into the platform so others can use it.


Diffs
-----

  trunk/KDE/kdevelop/languages/cpp/completionitem.cpp 929584 
  trunk/KDE/kdevplatform/language/CMakeLists.txt 929944 
  trunk/KDE/kdevplatform/language/codecompletion/codecompletionhelper.h PRE-CREATION 
  trunk/KDE/kdevplatform/language/codecompletion/codecompletionhelper.cpp PRE-CREATION 

Diff: http://reviewboard.kde.org/r/152/diff


Testing
-------

it compiles (I didn't change anything in the logic - just moved stuff around)


Thanks,

niko.sams





More information about the KDevelop-devel mailing list