VcsJob question and suggestion

[Matthew Woehlke]

Andreas Pakulat wrote:
> Right, a simple API like the following around a QPair.
> 
> VcsDiff::Type type()
> QByteArray firstBinary()
> QByteArray secondBinary()
> QString diff()
> QString firstText()
> QString secondText()

Agreed... and I see you beat me to it, thanks. :-)

Now... what about reconsidering VcsDiffType::DiffTerse (unified only)? I 
know we originally said 'no', but I don't think we condidered the case 
of 'give me a#1+diff(a#1,a#2), diff(a#2,a#3), diff(a#3,a#4), ...'. 
Obviously just the unified-diff is preferable in this case.

Name suggestions welcome, as usual (just that DiffUnified is already 
taken so maybe we should rename that first).

Also, shouldn't we drop the Vcs prefix inside VcsDiff? (e.g. 
s/VcsDiffType/DiffType)

-- 
Matthew
Ideas in this e-mail are larger than they appear and the writer may be 
smarter than he appears.