CMake 2.4.7 available for download
Matthew Woehlke
mw_triad at users.sourceforge.net
Wed Jul 18 19:59:45 UTC 2007
Andreas Pakulat wrote:
> On 18.07.07 11:11:00, Matthew Woehlke wrote:
>> Alexander Neundorf wrote:
>>> On Wednesday 18 July 2007 11:33, Matthew Woehlke wrote:
>>>> What about the kdevelop generator, does it make color makefiles now?
>>> No, unchanged.
>>> If you have a look at Source/cmGlobalKdevelopGenerator.cxx, you will find a
>>> line
>>> this->ToolSupportsColor = false;
>>>
>>> Change this to true.
>>> It would be nice if you could then go back in kdevelop history and find out if
>>> there were problems with the colored output with previous versions of
>>> kdevelop, and if so, at which version this changed.
>>> I'm quite sure it didn't work at some point, and I don't want to "break" older
>>> kdevelop versions for this.
>> Oy... anyone have any idea when, if ever, this was a problem?
>
> It doesn't matter wether it breaks any version older than 3.3.0 because
> those are completely unsupported. Even for 3.3.x we don't offer active
> support (we still host the code in branches/kdevelop because newer
> kdevelop only works with KDE 3.4 or older).
Sounds good.
> And svn history doesn't show any changes that would indicate a fix for
> coloured make output between 3.3.0 and now. There's one change though
> that might accidentally fix it, the introduction of the ActionFormat
> (introduced in April 2005, I doubt anybody using cmake is using such an
> ancient kdevelop)
>
> Maybe the change rather happened in cmake, i.e. in earlier versions it
> didn't use isatty to check for a tty but instead always printed
> colors?
Any cmake devs want to comment? This actually seems much more likely,
since I don't know why KDevelop would ever act like a pty.
Opinions from the cmake side? I don't see why it shouldn't be OK to fix
this, I mean you can always disable it by hand if it breaks, right? (But
AFAIK you can't force color makefiles on...?)
> PS: Feel free to forward this.
Done (well, cmake list CC'd back in).
--
Matthew
"A mouse is a device used to point at the xterm you want to type in."
--Kim Alm, A.S.R.
More information about the KDevelop-devel
mailing list