(UPDATED) astyle plugin - for astyle 1.19
Megan Webb
mwebb at unwired.com.au
Sun Oct 15 05:10:56 UTC 2006
Matt Rogers wrote:
> Perhaps the most important question: Does it still work? :)
>
> Comments about the code.
>
> astyle_widget.cpp:
>
> - AStyleWidget::styleChanged: the nice formatting of the sample text in the
> code was undone. AFAIK, there are no performance side effects from having
> nicely formatted code. Can you change it back to the way it was?
>
> astyle_part.cpp:
>
> - AStylePart::AStylePart: Why is the call to activePartChanged removed?
>
> I haven't been able to take a look at the UI yet.
>
All I can say at the moment is that it works for me. I made the changes.
Did some testing. Tried a clean build. Rebuild. Seems to work for me
without problems. So I'm hopeful that it will work for others.
If there is a 'do these tests before emailing' list that I should be
aware of?
Point me at it:)
AStyleWidget::styleChanged - removed the embedded newlines. Diff for
only the
astyle_widget.cpp file is attached. Still thinking how to have an
improved 'show the
effect of the option dislay'
AStylePart::AStylePart: - I'm not seeing that the call the
activePartChanged is removed.
I don't see any changes to astyle_part.cpp or astyle_part.h at all.
Am I missing something?
Thanks Alexander for your patches.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: astyle_widget.diff.bz2
Type: application/octet-stream
Size: 1758 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20061015/f5fb4df2/attachment.obj>
More information about the KDevelop-devel
mailing list