KDevelop 2.1 viewNextError() patch

[Falk Brettschneider]

Hi Marcus,

Marcus Gruendler wrote:

>Hi,
>
>I just noticed that when going to the next compile error (by pressing F4 or 
>selecting the menu entry) jumps to the correct line int the editor but does 
>not select the correct line in the "make output view".
>
>After a short inspection of the source in kdevelop/coutputwidget.cpp I 
>realised that the selecting code is commented out. Is there a special reason 
>for this? I uncommented the code and recompiled KDevelop - everything works 
>as expected.
>
>If it simply has been forgotten, please enable it again. I have attached a 
>patch which does this.
>
Yes. I commented it out because I didn't saw a sense in it and somehow 
there's heavy annoying flickering when running a program with many 
qDebug output on KDE3 because of any hidden text selection in the 
CMakeOutputView I haven't found until now. :-(

Why do we need to select text in that view at all?
What has it to do with jumping to the next error???
Please, enlight me.

Ciao,F at lk

>
>
>I am using the current CVS version of KDE_2_2_BRANCH, I hope this is the 
>correct version for KDevelop 2.1.
>
>Bye, Marcus
>
>
>------------------------------------------------------------------------
>
>Index: kdevelop/coutputwidget.cpp
>===================================================================
>RCS file: /home/kde/kdevelop/kdevelop/Attic/coutputwidget.cpp,v
>retrieving revision 1.3.2.4.2.10.2.12
>diff -u -r1.3.2.4.2.10.2.12 coutputwidget.cpp
>--- kdevelop/coutputwidget.cpp	2002/02/27 10:00:27	1.3.2.4.2.10.2.12
>+++ kdevelop/coutputwidget.cpp	2002/03/17 21:48:02
>@@ -197,7 +197,7 @@
>       ErrorDetails errorDetails = it.data();
>       if (!errorDetails.m_fileName.isEmpty() && errorDetails.m_lineNumber >= 0)
>       {
>-//?        selectLine(it.key());
>+        selectLine(it.key());
>         emit switchToFile(errorDetails.m_fileName, errorDetails.m_lineNumber);
>         return;
>       }
>@@ -217,7 +217,7 @@
>       ErrorDetails errorDetails = it.data();
>       if (!errorDetails.m_fileName.isEmpty() && errorDetails.m_lineNumber >= 0)
>       {
>-//?        selectLine(it.key());
>+        selectLine(it.key());
>         emit switchToFile(errorDetails.m_fileName, errorDetails.m_lineNumber);
>         return;
>       }
>




_________________________________________________________
Do You Yahoo!?
Get your free @yahoo.com address at http://mail.yahoo.com