[kdenlive] Review Request 126796: online resource -logs into users freesound accounts to get permission for HQ audio. Fixes archive.org video search new dependancy KF5WebKit. (libkf5webkit5-dev)

[Roger Morton]

> On Feb. 17, 2016, 9:21 p.m., Jean-Baptiste Mardelle wrote:
> > Thanks for the update, looks good to me now.
> > We will make the push to git in the next days, and after that add a CMakeList flag to conditionnaly disable the webkit dependency.

Cool. 

One thing that troubles me about it is that - because of the download method I use for the HQ files is not the same as the other downloads (because I had to pass authentication parameters) - it means that if you close the Resource Widget window while the download is still running the download will not complete. I think the other download jobs start some independant job that does keep running if you close out of Resource Widget. I was trying the figure out how to trap the close event and then raise a warning if you are closing while the job is still running. But I never figured out where to put that code. 
Oh well - nothing is ever perfect.


- Roger


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126796/#review92506
-----------------------------------------------------------


On Feb. 15, 2016, 1:08 p.m., Roger Morton wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126796/
> -----------------------------------------------------------
> 
> (Updated Feb. 15, 2016, 1:08 p.m.)
> 
> 
> Review request for Kdenlive and Vincent Pinon.
> 
> 
> Repository: kdenlive
> 
> 
> Description
> -------
> 
> online resource -logs into users freesound accounts to get permission for HQ audio. Fixes archive.org video search new dependancy KF5WebKit. (libkf5webkit5-dev)
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 5b7fd58 
>   src/qt-oauth-lib/CMakeLists.txt PRE-CREATION 
>   src/qt-oauth-lib/logindialog.h PRE-CREATION 
>   src/qt-oauth-lib/logindialog.cpp PRE-CREATION 
>   src/qt-oauth-lib/oauth2.h PRE-CREATION 
>   src/qt-oauth-lib/oauth2.cpp PRE-CREATION 
>   src/ui/freesound_ui.ui 55a453d 
>   src/ui/logindialog_ui.ui PRE-CREATION 
>   src/utils/abstractservice.h 0a6a4a7 
>   src/utils/archiveorg.h 5cdc84f 
>   src/utils/archiveorg.cpp 1be4d6f 
>   src/utils/freesound.h 27eefad 
>   src/utils/freesound.cpp d2b3c0e 
>   src/utils/openclipart.h 7a4df1e 
>   src/utils/openclipart.cpp adbba68 
>   src/utils/resourcewidget.h c171e3c 
>   src/utils/resourcewidget.cpp ddbfebe 
> 
> Diff: https://git.reviewboard.kde.org/r/126796/diff/
> 
> 
> Testing
> -------
> 
> Built. Tested file downloads from freesound. Auhenticates to freesound. keeps authenticated until you delete $HOME/.config/kde.org/kdenlive.conf 
> Archive.org video search is now working. Display animiated .gif as the preview file from Archive.org videos.
> No longer have to click search button twice to get it to do the search the first time it runs
> Option to not use personal freesound account and just use HQ preview file instead.
> Downloads low quality preview file in background and does not notify you of it finishing.
> 
> 
> File Attachments
> ----------------
> 
> tokens to settings patch
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/02/04/9529c467-2fa8-459e-84c5-a899ca4275ee__0002-move-token-storage-in-freesound-to-settings-file.patch
> 
> 
> Thanks,
> 
> Roger Morton
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdenlive/attachments/20160218/c069653b/attachment.html>