<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126796/">https://git.reviewboard.kde.org/r/126796/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 17th, 2016, 9:21 p.m. UTC, <b>Jean-Baptiste Mardelle</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Thanks for the update, looks good to me now.
We will make the push to git in the next days, and after that add a CMakeList flag to conditionnaly disable the webkit dependency.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Cool. </p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">One thing that troubles me about it is that - because of the download method I use for the HQ files is not the same as the other downloads (because I had to pass authentication parameters) - it means that if you close the Resource Widget window while the download is still running the download will not complete. I think the other download jobs start some independant job that does keep running if you close out of Resource Widget. I was trying the figure out how to trap the close event and then raise a warning if you are closing while the job is still running. But I never figured out where to put that code.
Oh well - nothing is ever perfect.</p></pre>
<br />
<p>- Roger</p>
<br />
<p>On February 15th, 2016, 1:08 p.m. UTC, Roger Morton wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Kdenlive and Vincent Pinon.</div>
<div>By Roger Morton.</div>
<p style="color: grey;"><i>Updated Feb. 15, 2016, 1:08 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdenlive
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">online resource -logs into users freesound accounts to get permission for HQ audio. Fixes archive.org video search new dependancy KF5WebKit. (libkf5webkit5-dev)</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Built. Tested file downloads from freesound. Auhenticates to freesound. keeps authenticated until you delete $HOME/.config/kde.org/kdenlive.conf
Archive.org video search is now working. Display animiated .gif as the preview file from Archive.org videos.
No longer have to click search button twice to get it to do the search the first time it runs
Option to not use personal freesound account and just use HQ preview file instead.
Downloads low quality preview file in background and does not notify you of it finishing.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/CMakeLists.txt <span style="color: grey">(5b7fd58)</span></li>
<li>src/qt-oauth-lib/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/qt-oauth-lib/logindialog.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/qt-oauth-lib/logindialog.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/qt-oauth-lib/oauth2.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/qt-oauth-lib/oauth2.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/ui/freesound_ui.ui <span style="color: grey">(55a453d)</span></li>
<li>src/ui/logindialog_ui.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/utils/abstractservice.h <span style="color: grey">(0a6a4a7)</span></li>
<li>src/utils/archiveorg.h <span style="color: grey">(5cdc84f)</span></li>
<li>src/utils/archiveorg.cpp <span style="color: grey">(1be4d6f)</span></li>
<li>src/utils/freesound.h <span style="color: grey">(27eefad)</span></li>
<li>src/utils/freesound.cpp <span style="color: grey">(d2b3c0e)</span></li>
<li>src/utils/openclipart.h <span style="color: grey">(7a4df1e)</span></li>
<li>src/utils/openclipart.cpp <span style="color: grey">(adbba68)</span></li>
<li>src/utils/resourcewidget.h <span style="color: grey">(c171e3c)</span></li>
<li>src/utils/resourcewidget.cpp <span style="color: grey">(ddbfebe)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126796/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/02/04/9529c467-2fa8-459e-84c5-a899ca4275ee__0002-move-token-storage-in-freesound-to-settings-file.patch">tokens to settings patch</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>