[Kdenlive-devel] Release and future...

[Till Theato]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 09/07/2011 10:51 AM, jb wrote:
> On 09/06/2011 11:21 PM, Till Theato wrote:
>>> So after a good coffee, here is my proposal:
>>> 
>>> 1 - Move the upgrade code from trackview to documentvalidator 
>>> (which is a more logical place for updates to the document)
>>> 
>>> 2 - Put the upgrade code in a different xml file, called like
>>> the kdenlive_id of the effect, for example frei0r.balanc0r
>>> upgrade code could be in a file called frei0rbalanc0r.upgrade
>>> 
>>> 3 - In documentvalidator, we load all upgrade xml in a QMap 
>>> <QString, QDomElement>  using the file name as key.
>>> 
>>> 4 - In documentvalidator, we parse all effects and if we have
>>> a version under the current one and the effect has an entry in
>>> the previously created list, we trigger the update.
>>> 
>>> What do you think about that?
>> Very good idea! Thanks a lot. I did an implementation similar to
>> your proposal in r5858. Still have to test, document, update the
>> frei0r filters, their xml files and write update rules. I will
>> try to do it asap.
> Great. One thing I would change is that you replace '.' with '_' in
> the file name for the update scripts, but then if an effect has an
> '_' in its name, that will break the logic and the update script
> will not be found. So I think it's better to keep the real kdenlive
> id name, like:
> 
> frei0r.levels.js

Changed in the mean time. However I am not sure if we really should
use the id. Maybe the MLT service name (tag name) might be better to
also include custom effects?

Otherwise the update functionality should be done now. The scripts for
the frei0r filters that used an invalid parameter range are also there.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk5si4kACgkQzwEyz7QP6nRihACgl4d0gGF0IPnbwbXuXUBYwtKh
StoAoN/SOsOtXKPSq5cYcc5QCl9bNfqJ
=lgBJ
-----END PGP SIGNATURE-----