[Kdenlive-devel] two new branches for review

Ray Lehtiniemi rayl at mail.com
Sun Apr 5 23:02:18 UTC 2009


hi guys

two more branches to consider:

--------------------------------------------------------------------
  git://kdenlive.git.sourceforge.net/gitroot/kdenlive rayl/review-11

Ray Lehtiniemi (4):
      Restore m_zoneStart from zonein when loading a document
      Modify clock.pgm luma to have constant angular velocity
      Fix runtime warnings about QAction::setShortcut()
      Eliminate two runtime warnings from the status bar.

 lumas/clock.pgm     |  Bin 414735 -> 414774 bytes
 src/kdenlivedoc.cpp |    1 +
 src/mainwindow.cpp  |   11 +++--------
 src/mainwindow.h    |    4 ++--
 4 files changed, 6 insertions(+), 10 deletions(-)

--------------------------------------------------------------------
  git://kdenlive.git.sourceforge.net/gitroot/kdenlive rayl/review-12

This branch implements the recommendation in Effective C++ which suggests that
all member variables should be explicitly initialized. It is split into one
commit per source file, so that git bisect will be usable to track down any
regressions that might be introduced by this patchset. (but i've been running
with this patchset for a few weeks now, and it seems stable enough)

Ray Lehtiniemi (57):
      Initialize all members in renderer/renderjob.cpp
      Initialize all members in src/abstractclipitem.cpp
      Initialize all members in src/abstractgroupitem.cpp
      Initialize all members in src/clipdurationdialog.cpp
      Initialize all members in src/clipitem.cpp
      Initialize all members in src/clipmanager.cpp
      Initialize all members in src/clipproperties.cpp
      Initialize all members in src/complexparameter.cpp
      Initialize all members in src/customruler.cpp
      Initialize all members in src/customtrackscene.cpp
      Initialize all members in src/customtrackview.cpp
      Initialize all members in src/docclipbase.cpp
      Initialize all members in src/dvdwizard.cpp
      Initialize all members in src/dvdwizardmenu.cpp
      Initialize all members in src/dvdwizardvob.cpp
      Initialize all members in src/editeffectcommand.cpp
      Initialize all members in src/edittransitioncommand.cpp
      Initialize all members in src/effectslistview.cpp
      Initialize all members in src/effectslistwidget.cpp
      Initialize all members in src/effectstackedit.cpp
      Initialize all members in src/effectstackview.cpp
      Initialize all members in src/gentime.cpp
      Initialize all members in src/geometryval.cpp
      Initialize all members in src/graphicsscenerectmove.cpp
      Initialize all members in src/guide.cpp
      Initialize all members in src/headertrack.cpp
      Initialize all members in src/initeffects.cpp
      Initialize all members in src/jogshuttle.cpp
      Initialize all members in src/kdenlivedoc.cpp
      Initialize all members in src/kdenlivesettingsdialog.cpp
      Initialize all members in src/keyframehelper.cpp
      Initialize all members in src/mainwindow.cpp
      Initialize all members in src/managecapturesdialog.cpp
      Initialize all members in src/markerdialog.cpp
      Initialize all members in src/monitor.cpp
      Initialize all members in src/monitormanager.cpp
      Initialize all members in src/parameterplotter.cpp
      Initialize all members in src/profilesdialog.cpp
      Initialize all members in src/projectlist.cpp
      Initialize all members in src/projectlistview.cpp
      Initialize all members in src/projectsettings.cpp
      Initialize all members in src/recmonitor.cpp
      Initialize all members in src/regiongrabber.cpp
      Initialize all members in src/renderer.cpp
      Initialize all members in src/renderwidget.cpp
      Initialize all members in src/slideshowclip.cpp
      Initialize all members in src/smallruler.cpp
      Initialize all members in src/spacerdialog.cpp
      Initialize all members in src/statusbarmessagelabel.cpp
      Initialize all members in src/titledocument.cpp
      Initialize all members in src/titlewidget.cpp
      Initialize all members in src/titlewidget.h
      Initialize all members in src/trackview.cpp
      Initialize all members in src/transition.cpp
      Initialize all members in src/transitionsettings.cpp
      Initialize all members in src/wizard.cpp
      Initialize all members in thumbnailer/westleypreview.cpp

 renderer/renderjob.cpp         |   24 +++++++----
 src/abstractclipitem.cpp       |    8 +++-
 src/abstractgroupitem.cpp      |    4 +-
 src/clipdurationdialog.cpp     |    7 ++-
 src/clipitem.cpp               |   23 ++++++----
 src/clipmanager.cpp            |    7 ++-
 src/clipproperties.cpp         |    1 +
 src/complexparameter.cpp       |   10 +++-
 src/customruler.cpp            |   18 +++++---
 src/customtrackscene.cpp       |    3 +-
 src/customtrackview.cpp        |   25 +++++++----
 src/docclipbase.cpp            |    7 ++-
 src/dvdwizard.cpp              |   12 ++++--
 src/dvdwizardmenu.cpp          |   14 +++++-
 src/dvdwizardvob.cpp           |    8 +++-
 src/editeffectcommand.cpp      |    2 +-
 src/edittransitioncommand.cpp  |    2 +-
 src/effectslistview.cpp        |    4 +-
 src/effectslistwidget.cpp      |    2 +
 src/effectstackedit.cpp        |    7 +++
 src/effectstackview.cpp        |    7 ++-
 src/gentime.cpp                |   12 +++---
 src/geometryval.cpp            |   11 +++--
 src/graphicsscenerectmove.cpp  |    6 ++-
 src/guide.cpp                  |    3 +-
 src/headertrack.cpp            |    6 +-
 src/initeffects.cpp            |    3 +-
 src/jogshuttle.cpp             |    3 +-
 src/kdenlivedoc.cpp            |   15 +++++-
 src/kdenlivesettingsdialog.cpp |   22 +++++++++-
 src/keyframehelper.cpp         |    1 +
 src/mainwindow.cpp             |   91 
++++++++++++++++++++++------------------
 src/managecapturesdialog.cpp   |    4 +-
 src/markerdialog.cpp           |    8 ++-
 src/monitor.cpp                |   25 +++++++----
 src/monitormanager.cpp         |    6 ++-
 src/parameterplotter.cpp       |   26 ++++++++----
 src/profilesdialog.cpp         |    4 ++
 src/projectlist.cpp            |   11 +++--
 src/projectlistview.cpp        |    3 +-
 src/projectsettings.cpp        |    6 ++-
 src/recmonitor.cpp             |   24 ++++++++--
 src/regiongrabber.cpp          |    6 ++-
 src/renderer.cpp               |   13 ++++-
 src/renderwidget.cpp           |    2 +
 src/slideshowclip.cpp          |    1 +
 src/smallruler.cpp             |   12 ++++--
 src/spacerdialog.cpp           |    5 +-
 src/statusbarmessagelabel.cpp  |    4 ++
 src/titledocument.cpp          |    4 +-
 src/titlewidget.cpp            |   18 ++++++--
 src/titlewidget.h              |   10 ++--
 src/trackview.cpp              |   18 ++++++--
 src/transition.cpp             |   11 +++--
 src/transitionsettings.cpp     |    4 ++
 src/wizard.cpp                 |   18 ++++++--
 thumbnailer/westleypreview.cpp |    4 +-
 57 files changed, 420 insertions(+), 195 deletions(-)


thanks
ray






More information about the Kdenlive mailing list