[Kdenlive-devel] two new branches for review

jb jb at kdenlive.org
Sun Apr 5 23:29:40 UTC 2009


On Monday 06 April 2009 01:02:18 Ray Lehtiniemi wrote:

>   git://kdenlive.git.sourceforge.net/gitroot/kdenlive rayl/review-11
>
> Ray Lehtiniemi (4):
>       Restore m_zoneStart from zonein when loading a document
>       Modify clock.pgm luma to have constant angular velocity
>       Fix runtime warnings about QAction::setShortcut()
>       Eliminate two runtime warnings from the status bar.

Hi!

Yes, the review-11 branch is ok, you can commit.

> --------------------------------------------------------------------
>   git://kdenlive.git.sourceforge.net/gitroot/kdenlive rayl/review-12
>
> This branch implements the recommendation in Effective C++ which suggests
> that all member variables should be explicitly initialized. It is split
> into one commit per source file, so that git bisect will be usable to track
> down any regressions that might be introduced by this patchset. (but i've
> been running with this patchset for a few weeks now, and it seems stable
> enough)

I don't have the energy to check all the initializations, but from what I saw 
it looks ok, and if you have been running it without problem, I guess it is. 

(One week left until release should be just enough to detect major issues)

regards.
jb






More information about the Kdenlive mailing list