D16469: Make NetworkPacket Metatype-capable

[Albert Vaca Cintora]

albertvaka added inline comments.

INLINE COMMENTS

> networkpacket.h:52
>  
> -    explicit NetworkPacket(const QString& type, const QVariantMap& body = {});
> +    explicit NetworkPacket(const QString& type = QStringLiteral("empty"), const QVariantMap& body = {});
> +    NetworkPacket(const NetworkPacket& other); // Copy constructor, required for QMetaType and queued signals

Is the default parameter needed? It like the fact that you get a compile error if no type is specified, otherwise one might think it is not necessary.

REPOSITORY
  R224 KDE Connect

REVISION DETAIL
  https://phabricator.kde.org/D16469

To: sredman, #kde_connect
Cc: albertvaka, apol, nicolasfella, kdeconnect, skymoore, wistak, dvalencia, rmenezes, julioc, Leptopoda, timothyc, jdvr, yannux, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20181028/1b49cdaf/attachment.html>