D16469: Make NetworkPacket Metatype-capable

[Simon Redman]

sredman added inline comments.

INLINE COMMENTS

> albertvaka wrote in networkpacket.h:52
> Is the default parameter needed? It like the fact that you get a compile error if no type is specified, otherwise one might think it is not necessary.

In order to work with Q_DECLARE_METATYPE, the class needs a default constructor. I agree with you, though. This is one of the things I least like about this change, since in a lot of cases when using with the metatype system you will use the default constructor, and such a NetworkPacket makes no sense!

REPOSITORY
  R224 KDE Connect

REVISION DETAIL
  https://phabricator.kde.org/D16469

To: sredman, #kde_connect
Cc: albertvaka, apol, nicolasfella, kdeconnect, skymoore, wistak, dvalencia, rmenezes, julioc, Leptopoda, timothyc, jdvr, yannux, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20181028/ff11cc01/attachment.html>