<table><tr><td style="">albertvaka added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D16469">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D16469#inline-89789">View Inline</a><span style="color: #4b4d51; font-weight: bold;">networkpacket.h:52</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="n">explicit</span> <span style="color: #004012">NetworkPacket</span><span class="p">(</span><span style="color: #aa4000">const</span> <span class="n">QString</span><span style="color: #aa2211">&</span> <span class="n">type</span><span class="p">,</span> <span style="color: #aa4000">const</span> <span class="n">QVariantMap</span><span style="color: #aa2211">&</span> <span class="n">body</span> <span style="color: #aa2211">=</span> <span class="p">{});</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">explicit</span> <span style="color: #004012">NetworkPacket</span><span class="p">(</span><span style="color: #aa4000">const</span> <span class="n">QString</span><span style="color: #aa2211">&</span> <span class="n">type<span class="bright"></span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">=</span></span><span class="bright"> </span><span class="n"><span class="bright">QStringLiteral</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"empty"</span></span><span class="bright"></span><span class="p"><span class="bright">)</span>,</span> <span style="color: #aa4000">const</span> <span class="n">QVariantMap</span><span style="color: #aa2211">&</span> <span class="n">body</span> <span style="color: #aa2211">=</span> <span class="p">{});</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">NetworkPacket</span><span class="p">(</span><span style="color: #aa4000">const</span> <span class="n">NetworkPacket</span><span style="color: #aa2211">&</span> <span class="n">other</span><span class="p">);</span> <span style="color: #74777d">// Copy constructor, required for QMetaType and queued signals</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Is the default parameter needed? It like the fact that you get a compile error if no type is specified, otherwise one might think it is not necessary.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R224 KDE Connect</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D16469">https://phabricator.kde.org/D16469</a></div></div><br /><div><strong>To: </strong>sredman, KDE Connect<br /><strong>Cc: </strong>albertvaka, apol, nicolasfella, kdeconnect, skymoore, wistak, dvalencia, rmenezes, julioc, Leptopoda, timothyc, jdvr, yannux, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, tctara<br /></div>