D10703: Build kdeconnect on sailfish and port some simple plugins

[Matthijs Tijink]

mtijink requested changes to this revision.
mtijink added a comment.
This revision now requires changes to proceed.


  I got some build errors, which I've added a comment for.
  
  Nice to see KDE Connect spreading to a different platform. Do you have some screenshots?

INLINE COMMENTS

> CMakeLists.txt:24
> +    include_directories(${CMAKE_SOURCE_DIR} ${QCA2_INCLUDEDIR})
> +    add_definitions(-DQT_NO_URL_CAST_FROM_STRING)
> +else()

Is there a reason you didn't add `-DQT_NO_KEYWORDS`?

> qasconst.h:4
> +
> +// this adds const to non-const objects (like std::as_const)
> +template <typename T>

This definitely needs the copyright notice from Qt. Also, a note were it came from would be good.

> CMakeLists.txt:7
> +    find_package(KF5 REQUIRED COMPONENTS Notifications)
> +    set(NOTIFICATION_LIB ${NNQT5_LIBRARIES})
> +endif()

I think this should be `KF5::Notifications`.

> CMakeLists.txt:7
> +    find_package(KF5 REQUIRED COMPONENTS Notifications)
> +    set(NOTIFICATION_LIB ${NNQT5_LIBRARIES})
> +endif()

I think this should be `KF5::Notifications`.

> sendnotificationsplugin.cpp:29
> +#ifdef SAILFISHOS
> +K_PLUGIN_FACTORY_WITH_JSON( KdeConnectPluginFactory, "kdeconnect_sendnotifications_sfos.json", registerPlugin< SendNotificationsPlugin >(); )
> +#else

Why is this separate file needed?

> kdeconnect-sfos.desktop:12
> +# a different app name in German locale (de).
> +Name[de]=kdeconnect-sfos

This line shouldn't be here, right?

> kdeconnect-sfos.changes.in:1
> +# Rename this file as kdeconnect-sfos.changes to include changelog
> +# entries in your RPM file.

I don't think rpm files normally live inside a KDE application repository. Is it possible to maintain these files in a separate repository?

REPOSITORY
  R224 KDE Connect

REVISION DETAIL
  https://phabricator.kde.org/D10703

To: piggz, #kde_connect, apol, mtijink
Cc: kossebau, mtijink, vonreth, apol, #kde_connect, nicolasfella, vhyvert, adeen-s, SemperPeritus, ahmedbesbes, daniel.z.tg, jeanv, tfella, aboudhar, seebauer, bugzy, MayeulC, menasshock, ach
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20180303/818d07c1/attachment-0001.html>