<table><tr><td style="">nicolasfella added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D12878">View Revision</a></tr></table><br /><div><div><p>There already is a unlock plugin that you can use as desktop counterpart in the desktop repo. <a href="https://cgit.kde.org/kdeconnect-kde.git/tree/plugins/lockdevice" class="remarkup-link" target="_blank" rel="noreferrer">https://cgit.kde.org/kdeconnect-kde.git/tree/plugins/lockdevice</a> To build it you must pass -DEXPERIMENTALAPP_ENABLED with the cmake command.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D12878#inline-70951">View Inline</a><span style="color: #4b4d51; font-weight: bold;">LockPlugin.java:38</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #74777d">/* Should it be available via UI?</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d"> @Override</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I would say yes</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D12878#inline-70950">View Inline</a><span style="color: #4b4d51; font-weight: bold;">LockTileService.java:77</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">private</span> <span style="color: #aa4000">boolean</span> <span style="color: #004012">unlockComputer</span><span style="color: #aa2211">()</span> <span style="color: #aa2211">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">BackgroundService</span><span style="color: #aa2211">.</span><span style="color: #354bb3">RunCommand</span><span style="color: #aa2211">(</span><span style="color: #aa4000">this</span><span style="color: #aa2211">,</span> <span class="n">service</span> <span style="color: #aa2211">-></span> <span style="color: #aa2211">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Why two different unlockComputer()?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D12878#inline-70948">View Inline</a><span style="color: #4b4d51; font-weight: bold;">LockTileService.java:98</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">private</span> <span style="color: #aa4000">boolean</span> <span style="color: #004012">unlockComputer</span><span style="color: #aa2211">(</span><span style="color: #aa4000">int</span> <span class="n">a</span><span style="color: #aa2211">)</span> <span style="color: #aa2211">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">BackgroundService</span><span style="color: #aa2211">.</span><span style="color: #354bb3">RunCommand</span><span style="color: #aa2211">(</span><span style="color: #aa4000">this</span><span style="color: #aa2211">,</span> <span class="n">service</span> <span style="color: #aa2211">-></span> <span style="color: #aa2211">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">What does a do?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D12878#inline-70949">View Inline</a><span style="color: #4b4d51; font-weight: bold;">LockTileService.java:101</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #74777d">//TODO: don't piggyback on runcommand</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">String</span> <span class="n">deviceId</span> <span style="color: #aa2211">=</span> <span class="n">getSharedPreferences</span><span style="color: #aa2211">(</span><span class="n">STATE_SELECTED_DEVICE</span><span style="color: #aa2211">,</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">Context</span><span style="color: #aa2211">.</span><span style="color: #354bb3">MODE_PRIVATE</span><span style="color: #aa2211">)</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Where is the preference written?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R225 KDE Connect - Android application</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D12878">https://phabricator.kde.org/D12878</a></div></div><br /><div><strong>To: </strong>bhav97, KDE Connect<br /><strong>Cc: </strong>nicolasfella, kdeconnect, jdvr, yannux, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, ndavis, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, ach, apol<br /></div>