D9559: Remove unused code in NotificationDbusInterface

Nicolas Fella noreply at phabricator.kde.org
Tue Feb 20 19:55:11 UTC 2018


nicolasfella added inline comments.

INLINE COMMENTS

> albertvaka wrote in notificationsdbusinterface.cpp:67
> Isn't this a typo and it should be "request" instead?
> 
> There is code on the Android side (ReceiveNotifications.java) that sends a "request" to receive all the current notifications.

It seems so. But I don't see why the Receive notificationsplugin (the phone) would ask the notificationsplugin (desktop) for it's notifications (they origin from the phone anyway). If anyone the sendnotifications plugin (desktop) should answer that request

REPOSITORY
  R224 KDE Connect

REVISION DETAIL
  https://phabricator.kde.org/D9559

To: nicolasfella, #kde_connect
Cc: albertvaka, #kde_connect
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20180220/4c4a4899/attachment.html>


More information about the KDEConnect mailing list