<table><tr><td style="">nicolasfella added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D9559" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D9559#inline-50185" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">albertvaka</span> wrote in <span style="color: #4b4d51; font-weight: bold;">notificationsdbusinterface.cpp:67</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">Isn't this a typo and it should be "request" instead?</p>
<p style="padding: 0; margin: 8px;">There is code on the Android side (ReceiveNotifications.java) that sends a "request" to receive all the current notifications.</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">It seems so. But I don't see why the Receive notificationsplugin (the phone) would ask the notificationsplugin (desktop) for it's notifications (they origin from the phone anyway). If anyone the sendnotifications plugin (desktop) should answer that request</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R224 KDE Connect</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D9559" rel="noreferrer">https://phabricator.kde.org/D9559</a></div></div><br /><div><strong>To: </strong>nicolasfella, KDE Connect<br /><strong>Cc: </strong>albertvaka, KDE Connect<br /></div>