D9559: Remove unused code in NotificationDbusInterface

Albert Vaca Cintora noreply at phabricator.kde.org
Sat Feb 17 10:33:27 UTC 2018


albertvaka added inline comments.

INLINE COMMENTS

> notificationsdbusinterface.cpp:67
>          removeNotification(id);
> -    } else if (np.get<bool>(QStringLiteral("isRequest"))) {
> -        for (const auto& n : qAsConst(m_notifications)) {

Isn't this a typo and it should be "request" instead?

There is code on the Android side (ReceiveNotifications.java) that sends a "request" to receive all the current notifications.

REPOSITORY
  R224 KDE Connect

REVISION DETAIL
  https://phabricator.kde.org/D9559

To: nicolasfella, #kde_connect
Cc: albertvaka, #kde_connect
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20180217/33fd6e54/attachment-0001.html>


More information about the KDEConnect mailing list