D6730: Determine which IP address to use for sshfs

[Jean Vincent]

jeanv marked an inline comment as done.
jeanv added a comment.


  In https://phabricator.kde.org/D6730#127238, @albertvaka wrote:
  
  > Looks good to me. I will merge this in as soon as I have a moment. Can you check my comment about IPv6? I think v6 should just work.
  
  
  Great, thanks :). Yep I answered.
  
  If this is accepted, then this revision <https://phabricator.kde.org/D6757> is no longer needed; I could update it to remove `getLocalIpAddress()` from the android side (if it is not going to be used). Is it OK?

INLINE COMMENTS

> albertvaka wrote in landevicelink.cpp:60
> I think we can remove the special case for IPv6, and it should just work? Hopefully :D

Just copying the address is what I had tried first, but it doesn't work, you have to construct a new `QHostAddress` with `toIPv4Address()` since Qt 5.6. Without that, `toString()` returns something like `::ffff:192.168.0.1` which sshfs doesn't like.
Here's what I found about this: https://bugreports.qt.io/browse/QTBUG-53298

REPOSITORY
  R224 KDE Connect

REVISION DETAIL
  https://phabricator.kde.org/D6730

To: jeanv, #kde_connect, albertvaka
Cc: albertvaka, apol, nicolasfella, sredman, tfella, aboudhar, seebauer, progwolff, MayeulC, menasshock, ach, hkaelberer
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20170721/93c7bb0d/attachment.html>