D6730: Determine which IP address to use for sshfs

Albert Vaca Cintora noreply at phabricator.kde.org
Fri Jul 21 16:25:43 UTC 2017


albertvaka accepted this revision.
albertvaka added a comment.
This revision is now accepted and ready to land.


  Looks good to me. I will merge this in as soon as I have a moment. Can you check my comment about IPv6? I think v6 should just work.

INLINE COMMENTS

> landevicelink.cpp:60
> +    QHostAddress addr = socket->peerAddress();
> +    mHostAddress = (addr.protocol() == QAbstractSocket::IPv6Protocol) ? QHostAddress(addr.toIPv4Address()) : addr;
> +

I think we can remove the special case for IPv6, and it should just work? Hopefully :D

REPOSITORY
  R224 KDE Connect

REVISION DETAIL
  https://phabricator.kde.org/D6730

To: jeanv, #kde_connect, albertvaka
Cc: albertvaka, apol, nicolasfella, sredman, tfella, aboudhar, seebauer, progwolff, MayeulC, menasshock, ach, hkaelberer
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20170721/d223e690/attachment-0001.html>


More information about the KDEConnect mailing list