D6730: Determine which IP address to use for sshfs

[Jean Vincent]

jeanv marked 2 inline comments as done.
jeanv added inline comments.

INLINE COMMENTS

> albertvaka wrote in mounter.cpp:117
> Maybe you can add a function to device that returns the IP directly?
> 
> m_sftp->device()->getLocalIpAddress()
> 
> That function would be responsible of finding a LanDeviceLink for the device, and if it found one get the IP from it.
> 
> If the device doesn't have a LanDeviceLink, this function could return an empty QHostAddress object, so the plugin prints an error and doesn't try to connect.

Yes I was just realizing that while rereading the code. There's no reason to expose the link, you're right.

REPOSITORY
  R224 KDE Connect

REVISION DETAIL
  https://phabricator.kde.org/D6730

To: jeanv, #kde_connect, albertvaka
Cc: albertvaka, apol, nicolasfella, sredman, tfella, aboudhar, seebauer, progwolff, MayeulC, menasshock, ach, hkaelberer
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20170721/0fe9c89e/attachment-0001.html>