D7209: Fix Notifications in Plasmoid

Nicolas Fella noreply at phabricator.kde.org
Wed Aug 9 00:09:04 UTC 2017


nicolasfella added inline comments.

INLINE COMMENTS

> apol wrote in notificationsdbusinterface.cpp:129
> I'd say it's fine to keep these debug statements. They're showing an error after all and debug is very easy to filter out.

These produce a lot of output which seems to be false alarms

> apol wrote in notificationsdbusinterface.cpp:143
> Can you elaborate on this? I'm not sure where it's from, maybe needs a comment?

I found this commented out in the code. The goal is to remove the notification from the plasmoid without deleting the noti object because we still want to use it

REPOSITORY
  R224 KDE Connect

REVISION DETAIL
  https://phabricator.kde.org/D7209

To: nicolasfella, #kde_connect, apol
Cc: apol, #kde_connect, tfella, aboudhar, seebauer, progwolff, MayeulC, menasshock, ach, hkaelberer
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20170809/d6551c38/attachment.html>


More information about the KDEConnect mailing list