D7209: Fix Notifications in Plasmoid

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> notificationsdbusinterface.h:61
>  private /*methods*/:
> -    void removeNotification(const QString& internalId);
> +    void removeNotification(const QString& internalId, bool update=false);
>      QString newId(); //Generates successive identifitiers to use as public ids

Please avoid a Boolean trap, use an `enum` of some sort instead. If you see a `removeNotification("foo", false)` you cannot tell at a glance what `false` means.

REPOSITORY
  R224 KDE Connect

REVISION DETAIL
  https://phabricator.kde.org/D7209

To: nicolasfella, #kde_connect, apol
Cc: broulik, apol, #kde_connect, tfella, aboudhar, seebauer, progwolff, MayeulC, menasshock, ach, hkaelberer
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20170809/7566d1c7/attachment-0001.html>