D7209: Fix Notifications in Plasmoid

[Aleix Pol Gonzalez]

apol requested changes to this revision.
apol added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> notificationsdbusinterface.cpp:129
>      if (!mInternalIdToPublicId.contains(internalId)) {
> -        qCDebug(KDECONNECT_PLUGIN_NOTIFICATION) << "Not found noti by internal Id: " << internalId;
> +        //qCDebug(KDECONNECT_PLUGIN_NOTIFICATION) << "Not found noti by internal Id: " << internalId;
>          return;

I'd say it's fine to keep these debug statements. They're showing an error after all and debug is very easy to filter out.

> notificationsdbusinterface.cpp:143
> +    if (update){
> +        QDBusConnection::sessionBus().unregisterObject(mDevice->dbusPath()+"/notifications/"+publicId);
> +    } else {

Can you elaborate on this? I'm not sure where it's from, maybe needs a comment?

REPOSITORY
  R224 KDE Connect

REVISION DETAIL
  https://phabricator.kde.org/D7209

To: nicolasfella, #kde_connect, apol
Cc: apol, #kde_connect, tfella, aboudhar, seebauer, progwolff, MayeulC, menasshock, ach, hkaelberer
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20170808/0df8dac3/attachment.html>