Review Request 129144: [KCM] Don't hardcode hyperlink color

Kai Uwe Broulik kde at privat.broulik.de
Tue Oct 11 09:09:48 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129144/
-----------------------------------------------------------

(Updated Oct. 11, 2016, 9:09 a.m.)


Status
------

This change has been marked as submitted.


Review request for kdeconnect.


Changes
-------

Submitted with commit 6ca3f98748ffab681ab953e2ef4a5cfdcbfd6e65 by Kai Uwe Broulik to branch 1.x.


Repository: kdeconnect-kde


Description
-------

Let the theme come up with a theme color which knows best to ensure contrast and readability.


Diffs
-----

  kcm/kcm.ui 000a875 

Diff: https://git.reviewboard.kde.org/r/129144/diff/


Testing
-------

I now get pink hyperlinks in "honeycomb" colorscheme and a more readable blue for dark breeze

As criticized here https://youtu.be/eKzCftUmnyY?t=58m11s


File Attachments
----------------

Readable font
  https://git.reviewboard.kde.org/media/uploaded/files/2016/10/10/96e50d89-5910-4418-ad5e-123048cc3121__Screenshot_20161010_231155.png


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20161011/022de5dd/attachment.html>


More information about the KDEConnect mailing list