Review Request 129144: [KCM] Don't hardcode hyperlink color

[Albert Vaca Cintora]

> On Oct. 10, 2016, 3:02 p.m., Aleix Pol Gonzalez wrote:
> > It should go to 1.x
> 
> Kai Uwe Broulik wrote:
>     Can that go into 1.x given it changes strings to be translated?

I'll ping the i18n mailing list, so they have time to translate it before the next release.

And if you are worried about distros like Debian which don't like new strings in patch releases: well, they will probably find any other excuse to ship 0.7 or some 2-year old version anyway, so I don't care anymore.


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129144/#review99918
-----------------------------------------------------------


On Oct. 10, 2016, 2:14 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129144/
> -----------------------------------------------------------
> 
> (Updated Oct. 10, 2016, 2:14 p.m.)
> 
> 
> Review request for kdeconnect.
> 
> 
> Repository: kdeconnect-kde
> 
> 
> Description
> -------
> 
> Let the theme come up with a theme color which knows best to ensure contrast and readability.
> 
> 
> Diffs
> -----
> 
>   kcm/kcm.ui 000a875 
> 
> Diff: https://git.reviewboard.kde.org/r/129144/diff/
> 
> 
> Testing
> -------
> 
> I now get pink hyperlinks in "honeycomb" colorscheme and a more readable blue for dark breeze
> 
> As criticized here https://youtu.be/eKzCftUmnyY?t=58m11s
> 
> 
> File Attachments
> ----------------
> 
> Readable font
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/10/10/96e50d89-5910-4418-ad5e-123048cc3121__Screenshot_20161010_231155.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20161011/7b9b6e7d/attachment-0001.html>