Review Request 129144: [KCM] Don't hardcode hyperlink color

Tue Oct 11 08:08:46 UTC 2016

> On Okt. 10, 2016, 10:02 nachm., Aleix Pol Gonzalez wrote:
> > It should go to 1.x

Can that go into 1.x given it changes strings to be translated?

- Kai Uwe

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129144/#review99918
-----------------------------------------------------------

On Okt. 10, 2016, 9:14 nachm., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129144/
> -----------------------------------------------------------
> 
> (Updated Okt. 10, 2016, 9:14 nachm.)
> 
> 
> Review request for kdeconnect.
> 
> 
> Repository: kdeconnect-kde
> 
> 
> Description
> -------
> 
> Let the theme come up with a theme color which knows best to ensure contrast and readability.
> 
> 
> Diffs
> -----
> 
>   kcm/kcm.ui 000a875 
> 
> Diff: https://git.reviewboard.kde.org/r/129144/diff/
> 
> 
> Testing
> -------
> 
> I now get pink hyperlinks in "honeycomb" colorscheme and a more readable blue for dark breeze
> 
> As criticized here https://youtu.be/eKzCftUmnyY?t=58m11s
> 
> 
> File Attachments
> ----------------
> 
> Readable font
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/10/10/96e50d89-5910-4418-ad5e-123048cc3121__Screenshot_20161010_231155.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20161011/5ea3bcdd/attachment.html>