Review Request 129144: [KCM] Don't hardcode hyperlink color
Aleix Pol Gonzalez
aleixpol at kde.org
Mon Oct 10 22:02:14 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129144/#review99918
-----------------------------------------------------------
Ship it!
It should go to 1.x
- Aleix Pol Gonzalez
On Oct. 10, 2016, 11:14 p.m., Kai Uwe Broulik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129144/
> -----------------------------------------------------------
>
> (Updated Oct. 10, 2016, 11:14 p.m.)
>
>
> Review request for kdeconnect.
>
>
> Repository: kdeconnect-kde
>
>
> Description
> -------
>
> Let the theme come up with a theme color which knows best to ensure contrast and readability.
>
>
> Diffs
> -----
>
> kcm/kcm.ui 000a875
>
> Diff: https://git.reviewboard.kde.org/r/129144/diff/
>
>
> Testing
> -------
>
> I now get pink hyperlinks in "honeycomb" colorscheme and a more readable blue for dark breeze
>
> As criticized here https://youtu.be/eKzCftUmnyY?t=58m11s
>
>
> File Attachments
> ----------------
>
> Readable font
> https://git.reviewboard.kde.org/media/uploaded/files/2016/10/10/96e50d89-5910-4418-ad5e-123048cc3121__Screenshot_20161010_231155.png
>
>
> Thanks,
>
> Kai Uwe Broulik
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20161010/82961a7a/attachment.html>
More information about the KDEConnect
mailing list