Review Request 128273: MPRIS: Read list of allowed actions for the player, and enforce restrictions. (Android)

[Saikrishna Arcot]

> On June 28, 2016, 3:07 p.m., Albert Vaca Cintora wrote:
> > src/org/kde/kdeconnect/Plugins/MprisPlugin/MprisPlugin.java, lines 148-152
> > <https://git.reviewboard.kde.org/r/128273/diff/1/?file=469712#file469712line148>
> >
> >     It might be better to make the default value be always true: Otherwise, if you change from a player which supports nothing (so most buttons are disabled) to a player that might support more things but doesn't say so (it doesn't expose any of the can* properties), we will be hiding buttons which might work. 
> >     
> >     As Aleix said, some players provide really bad MPRIS data.

Done. The new code is in the `setPlayer()` method; changing the default value in the `getBoolean()` calls will cause non-working functions to appear again when the player is paused/skipped.


> On June 28, 2016, 3:07 p.m., Albert Vaca Cintora wrote:
> > src/org/kde/kdeconnect/Plugins/MprisPlugin/MprisActivity.java, line 178
> > <https://git.reviewboard.kde.org/r/128273/diff/1/?file=469711#file469711line178>
> >
> >     It would be awesome if we could remove this hack now that you detect the actual capabilities, but I think Spotify says it supports everything and it's not true... so we are stuck with the hack.

According to the comments there, Spotify also doesn't support telling the actual position, and there's no way in MPRIS to express this, so that bit of the hack might have to stay.


- Saikrishna


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128273/#review96936
-----------------------------------------------------------


On June 21, 2016, 3:03 p.m., Saikrishna Arcot wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128273/
> -----------------------------------------------------------
> 
> (Updated June 21, 2016, 3:03 p.m.)
> 
> 
> Review request for kdeconnect.
> 
> 
> Repository: kdeconnect-android
> 
> 
> Description
> -------
> 
> Read list of allowed actions for the player sent from KDE, and hide buttons that perform actions that aren't allowed based on MPRIS.
> 
> KDE side of change is in /r/128271.
> 
> 
> Diffs
> -----
> 
>   src/org/kde/kdeconnect/Plugins/MprisPlugin/MprisActivity.java 8905d14c88c01a272001f7ddeb53f744305602b2 
>   src/org/kde/kdeconnect/Plugins/MprisPlugin/MprisPlugin.java 962d9df11eb268e4651442c10c88f16d0fb471cc 
> 
> Diff: https://git.reviewboard.kde.org/r/128273/diff/
> 
> 
> Testing
> -------
> 
> Tested with VLC and a client I'm working on that only supports pausing and skipping to the next track.
> 
> 
> Thanks,
> 
> Saikrishna Arcot
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20160628/923f4944/attachment.html>