Review Request 128273: MPRIS: Read list of allowed actions for the player, and enforce restrictions. (Android)
Kai Uwe Broulik
kde at privat.broulik.de
Tue Jun 28 20:42:30 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128273/#review96938
-----------------------------------------------------------
I think previous/pause/next should still be shown but disabled/grayed out.
At least that's what we do in Plasma and what all players I know do.
- Kai Uwe Broulik
On Juni 21, 2016, 8:03 nachm., Saikrishna Arcot wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128273/
> -----------------------------------------------------------
>
> (Updated Juni 21, 2016, 8:03 nachm.)
>
>
> Review request for kdeconnect.
>
>
> Repository: kdeconnect-android
>
>
> Description
> -------
>
> Read list of allowed actions for the player sent from KDE, and hide buttons that perform actions that aren't allowed based on MPRIS.
>
> KDE side of change is in /r/128271.
>
>
> Diffs
> -----
>
> src/org/kde/kdeconnect/Plugins/MprisPlugin/MprisActivity.java 8905d14c88c01a272001f7ddeb53f744305602b2
> src/org/kde/kdeconnect/Plugins/MprisPlugin/MprisPlugin.java 962d9df11eb268e4651442c10c88f16d0fb471cc
>
> Diff: https://git.reviewboard.kde.org/r/128273/diff/
>
>
> Testing
> -------
>
> Tested with VLC and a client I'm working on that only supports pausing and skipping to the next track.
>
>
> Thanks,
>
> Saikrishna Arcot
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20160628/52591e25/attachment.html>
More information about the KDEConnect
mailing list