Review Request 128273: MPRIS: Read list of allowed actions for the player, and enforce restrictions. (Android)

[Albert Vaca Cintora]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128273/#review96936
-----------------------------------------------------------




src/org/kde/kdeconnect/Plugins/MprisPlugin/MprisActivity.java (line 178)
<https://git.reviewboard.kde.org/r/128273/#comment65511>

    It would be awesome if we could remove this hack now that you detect the actual capabilities, but I think Spotify says it supports everything and it's not true... so we are stuck with the hack.



src/org/kde/kdeconnect/Plugins/MprisPlugin/MprisPlugin.java (lines 148 - 152)
<https://git.reviewboard.kde.org/r/128273/#comment65510>

    It might be better to make the default value be always true: Otherwise, if you change from a player which supports nothing (so most buttons are disabled) to a player that might support more things but doesn't say so (it doesn't expose any of the can* properties), we will be hiding buttons which might work. 
    
    As Aleix said, some players provide really bad MPRIS data.


- Albert Vaca Cintora


On jun. 21, 2016, 1:03 p.m., Saikrishna Arcot wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128273/
> -----------------------------------------------------------
> 
> (Updated jun. 21, 2016, 1:03 p.m.)
> 
> 
> Review request for kdeconnect.
> 
> 
> Repository: kdeconnect-android
> 
> 
> Description
> -------
> 
> Read list of allowed actions for the player sent from KDE, and hide buttons that perform actions that aren't allowed based on MPRIS.
> 
> KDE side of change is in /r/128271.
> 
> 
> Diffs
> -----
> 
>   src/org/kde/kdeconnect/Plugins/MprisPlugin/MprisActivity.java 8905d14c88c01a272001f7ddeb53f744305602b2 
>   src/org/kde/kdeconnect/Plugins/MprisPlugin/MprisPlugin.java 962d9df11eb268e4651442c10c88f16d0fb471cc 
> 
> Diff: https://git.reviewboard.kde.org/r/128273/diff/
> 
> 
> Testing
> -------
> 
> Tested with VLC and a client I'm working on that only supports pausing and skipping to the next track.
> 
> 
> Thanks,
> 
> Saikrishna Arcot
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20160628/97257d4e/attachment-0001.html>