Review Request 124120: Move the generation of dbus interfaces into interfaces/

Aleix Pol Gonzalez aleixpol at kde.org
Thu Jun 18 17:08:06 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124120/
-----------------------------------------------------------

(Updated June 18, 2015, 5:08 p.m.)


Status
------

This change has been marked as submitted.


Review request for kdeconnect.


Changes
-------

Submitted with commit 68b206e5259bd3407e0d1e9317c34d2595563d3b by Aleix Pol to branch master.


Repository: kdeconnect-kde


Description
-------

Simplifies the code altogether by centralizing the generation into 1 call that does all the steps.


Diffs
-----

  cmake/DbusInterfaceMacros.cmake 2c49753 
  core/CMakeLists.txt 4d75251 
  interfaces/CMakeLists.txt bae0cff 
  plugins/battery/CMakeLists.txt cfb799a 
  plugins/mprisremote/CMakeLists.txt 0392249 
  plugins/notifications/CMakeLists.txt 233fae1 
  plugins/sftp/CMakeLists.txt 7f68e0c 

Diff: https://git.reviewboard.kde.org/r/124120/diff/


Testing
-------

Just works.


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150618/fc047d96/attachment.html>


More information about the KDEConnect mailing list