Review Request 124120: Move the generation of dbus interfaces into interfaces/

[Aleix Pol Gonzalez]

> On June 18, 2015, 6:57 a.m., Albert Vaca Cintora wrote:
> > Just one change: Remove the CMake macro "generate_and_install_dbus_interface" if we don't use it anymore, and move "geninterface" to that file, so that we can use it in more places (and easily copied over to other projects). You will need to add an extra parameter to "geninterface", to specify the sources variable to add the interface to.
> 
> Aleix Pol Gonzalez wrote:
>     It's already removed, the whole file.
>     
>     I don't think we want to re-use this in other projects. I'll move it into a separate file, nevertheless.

Hm, no, the macro uses local variables. Splitting into a separate file would make it necessary to pass them, adding quite a readability burden, IMHO.


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124120/#review81547
-----------------------------------------------------------


On June 18, 2015, 5:49 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124120/
> -----------------------------------------------------------
> 
> (Updated June 18, 2015, 5:49 a.m.)
> 
> 
> Review request for kdeconnect.
> 
> 
> Repository: kdeconnect-kde
> 
> 
> Description
> -------
> 
> Simplifies the code altogether by centralizing the generation into 1 call that does all the steps.
> 
> 
> Diffs
> -----
> 
>   cmake/DbusInterfaceMacros.cmake 2c49753 
>   core/CMakeLists.txt 4d75251 
>   interfaces/CMakeLists.txt bae0cff 
>   plugins/battery/CMakeLists.txt cfb799a 
>   plugins/mprisremote/CMakeLists.txt 0392249 
>   plugins/notifications/CMakeLists.txt 233fae1 
>   plugins/sftp/CMakeLists.txt 7f68e0c 
> 
> Diff: https://git.reviewboard.kde.org/r/124120/diff/
> 
> 
> Testing
> -------
> 
> Just works.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150618/fe8fa462/attachment-0001.html>