Review Request 122054: Use co-installable qca-qt5 version

Heiko Becker heirecka at exherbo.org
Fri Jan 16 05:36:35 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122054/
-----------------------------------------------------------

(Updated Jan. 16, 2015, 5:36 a.m.)


Status
------

This change has been marked as submitted.


Review request for kdeconnect.


Repository: kdeconnect-kde


Description
-------

If both qt4 and qt5 versions of qca are present the build of the
frameworks branch tries to find Qt4 pulled in by qca and thus fails.

This change is similiar to what has been done to konversation and
muon:
http://quickgit.kde.org/?p=konversation.git&a=commit&h=3aa918b5e3ac0f90a76d55c2bab12fafcbb1279b
http://quickgit.kde.org/?p=muon.git&a=commit&h=fd76f5ad43228689127cb4f12c0fbc6d65f4b373


Diffs
-----

  CMakeLists.txt b4678cb 
  core/CMakeLists.txt faaac94 
  plugins/sftp/CMakeLists.txt ae10b5f 
  tests/CMakeLists.txt a02dd24 

Diff: https://git.reviewboard.kde.org/r/122054/diff/


Testing
-------

Successfully built and paired phone.


Thanks,

Heiko Becker

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150116/262bc907/attachment.html>


More information about the KDEConnect mailing list