Review Request 122054: Use co-installable qca-qt5 version
Albert Vaca Cintora
albertvaka at gmail.com
Fri Jan 16 05:37:15 UTC 2015
> On gen. 14, 2015, 7:52 p.m., Albert Vaca Cintora wrote:
> > Thanks!
>
> Heiko Becker wrote:
> Forgot to mention that I don't have commit access, so I need someone to push this for me. Thanks.
Done!
- Albert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122054/#review74024
-----------------------------------------------------------
On gen. 16, 2015, 6:36 a.m., Heiko Becker wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122054/
> -----------------------------------------------------------
>
> (Updated gen. 16, 2015, 6:36 a.m.)
>
>
> Review request for kdeconnect.
>
>
> Repository: kdeconnect-kde
>
>
> Description
> -------
>
> If both qt4 and qt5 versions of qca are present the build of the
> frameworks branch tries to find Qt4 pulled in by qca and thus fails.
>
> This change is similiar to what has been done to konversation and
> muon:
> http://quickgit.kde.org/?p=konversation.git&a=commit&h=3aa918b5e3ac0f90a76d55c2bab12fafcbb1279b
> http://quickgit.kde.org/?p=muon.git&a=commit&h=fd76f5ad43228689127cb4f12c0fbc6d65f4b373
>
>
> Diffs
> -----
>
> CMakeLists.txt b4678cb
> core/CMakeLists.txt faaac94
> plugins/sftp/CMakeLists.txt ae10b5f
> tests/CMakeLists.txt a02dd24
>
> Diff: https://git.reviewboard.kde.org/r/122054/diff/
>
>
> Testing
> -------
>
> Successfully built and paired phone.
>
>
> Thanks,
>
> Heiko Becker
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150116/9d0c5e84/attachment.html>
More information about the KDEConnect
mailing list