Review Request 116645: Simplify a lot the code in SocketLinearReader

Àlex Fiestas afiestas at kde.org
Mon Apr 14 20:06:50 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116645/
-----------------------------------------------------------

(Updated April 14, 2014, 8:06 p.m.)


Status
------

This change has been marked as submitted.


Review request for kdeconnect.


Repository: kdeconnect-kde


Description
-------

Use QIODevice canReadLine and readLine instead of our own implementation.


Diffs
-----

  kded/backends/lan/socketlinereader.cpp 4cd8ef0 

Diff: https://git.reviewboard.kde.org/r/116645/diff/


Testing
-------

Unittest pass, ping and mpris seem to be responsive and work with no problem.


Thanks,

Àlex Fiestas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20140414/df2b15e9/attachment.html>


More information about the KDEConnect mailing list